Updates Stylelint to 15.0.0 #298
Conversation
🦋 Changeset detectedLatest commit: f68c04e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@nicholasio after the upgrade I can go and check the lining once we upgrade the packages |
|
Any idea why the test failed on node 16? |
|
@nicholasio failed on linting. Only lints on Node 16. Checking the issue, what fails linting is stylelint for the 10up-theme. I think after things are published I can go and update everything there? |
# Conflicts: # package-lock.json # packages/stylelint-config/package.json
# Conflicts: # package-lock.json
|
The failure is legit and not specific to node 16
We only run linting in one of the jobs and apparently, our deps update is forcing everything to be react 18 now. I'm wondering if we should just make this a warning instead of an error. |
| @@ -50,7 +51,7 @@ | |||
| "peerDependencies": { | |||
| "@babel/core": "^7.21.4", | |||
| "@babel/eslint-parser": "^7.21.3", | |||
| "@wordpress/eslint-plugin": "^13.10.0", | |||
| "@wordpress/eslint-plugin": "^14.9.0", | |||
There was a problem hiding this comment.
I believe this is forcing react 18
|
These new errors aren't what they used to be! See https://github.com/10up/10up-toolkit/actions/runs/5738199032/job/15551300090#step:8:76 That said, I'm wondering if we should upgrade to React 18 |
| @@ -1,5 +1,5 @@ | |||
| // Test comment | |||
| @import "./components/sass-component"; | |||
| @import url("./components/sass-component.scss"); | |||
There was a problem hiding this comment.
@nicholasio thoughts here? I think being consistent between scss and no scss is the way to go. Doesn't seem possible to have one linting rule just for scss rules so it's one or the other.
| @@ -1,5 +1,5 @@ | |||
| // Test comment | |||
| @import "./components/sass-component"; | |||
| @import url("./components/sass-component.scss"); | |||
Related Issue/RFC: #284
Description of the Change
This updates
stylelintto version15.0.0and decouple from@wordpress/stylelint-config. Upgrading to this should be painless.Expanding a bit:
Stylelint 15 soft deprecates 76 stylistic rules of which we were leveraging 51 rules. Right now, any effort on
@wordpress/stylelint-configis halted given they'll need to discuss what to do with those rules so forking from them seemed the shortest path that allows us to move forward.This has been discussed on #295
Checklist: